gn: handle continued suffix comments

gn: handle continued suffix comments

Rebased on https://codereview.chromium.org/588893006/

Comments that look like standalone line comments but immediately follow
a previous suffix comment should be considered suffix as well so they
can be added to the same node.

R=brettw@chromium.org
BUG=348474
Committed: https://crrev.com/7b80f170ea002576168f78502b6456697942a6df
Cr-Commit-Position: refs/heads/master@{#296339}

[brettw, 2014-09-23 21:49:10]

https://codereview.chromium.org/595753002/diff/1/tools/gn/parser_unittest.cc
File tools/gn/parser_unittest.cc (right):

https://codereview.chromium.org/595753002/diff/1/tools/gn/parser_unittest.cc#...
tools/gn/parser_unittest.cc:592: "            # then the end.\n"
What about this code:

sources = [ "a" ]  # This source is awesone
# Add some deps
deps = [ ":fpp" ]

Does your code treat it as a continuation? Maybe we should force the # to align
horizontally for them to be considered the same? Can we get a test case for
this?

[scottmg, 2014-09-23 22:37:40]

Patchset #2 (id:20001) has been deleted

[scottmg, 2014-09-23 22:39:15]

Patchset #2 (id:40001) has been deleted

[scottmg, 2014-09-23 22:41:01]

Thanks

https://codereview.chromium.org/595753002/diff/1/tools/gn/parser_unittest.cc
File tools/gn/parser_unittest.cc (right):

https://codereview.chromium.org/595753002/diff/1/tools/gn/parser_unittest.cc#...
tools/gn/parser_unittest.cc:592: "            # then the end.\n"
On 2014/09/23 21:49:09, brettw wrote:
> What about this code:
> 
> sources = [ "a" ]  # This source is awesone
> # Add some deps
> deps = [ ":fpp" ]
> 
> Does your code treat it as a continuation? Maybe we should force the # to
align
> horizontally for them to be considered the same? Can we get a test case for
> this?

Yeah, it does treat it as a continuation. I noticed that happening (and updated
the tokenizer test), but I wasn't entirely sure if it was correct or not.

Same column seems like a reasonable heuristic, changed to enforce that.

Added test to tokenizer to make sure they're correctly characterized. As it
happens they weren't actually aligned in this test! (because of the \"s).

[brettw, 2014-09-23 23:17:39]

lgtm

[scottmg, 2014-09-23 23:19:17]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-09-23 23:20:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595753002/60001

[commit-bot: I haz the power, 2014-09-23 23:26:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 23:26:15]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/59735)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/64611)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[scottmg, 2014-09-24 02:42:20]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-09-24 02:43:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595753002/60001

[commit-bot: I haz the power, 2014-09-24 03:35:23]

Committed patchset #2 (id:60001) as e52b935fed1b5c1f178fdb6449766f3516e3f65c

[commit-bot: I haz the power, 2014-09-24 03:35:55]

Patchset 2 (id:??) landed as
https://crrev.com/7b80f170ea002576168f78502b6456697942a6df
Cr-Commit-Position: refs/heads/master@{#296339}