Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 595733002: Revert of Class for allocating a chunk of memory for RenderPass (Closed)

Created:
6 years, 3 months ago by weiliangc
Modified:
6 years, 3 months ago
Reviewers:
danakj, jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, Ian Vollick, enne (OOO), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojojojo
Project:
chromium
Visibility:
Public.

Description

Revert of Class for allocating a chunk of memory for RenderPass (patchset #31 id:660001 of https://codereview.chromium.org/400463002/) Reason for revert: Broke cc_unittest for Linux ASan bot Original issue's description: > Class for allocating a chunk of memory for RenderPass > > For DrawQuads and SharedQuadState, RenderPass used allocate them one by > one whenever needed. This new class helps RenderPass manages allocation > and iteration of those two types. This container allocates a chunk of > memory at one time and hands out raw pointers. It also provides iterator > and reverse iterators for going through its contents. > > Unittest for ListContainer makes sure the raw pointers it hands out are > valid and iterator has same behavior as vector iterators. > > Follows 398533002, and 404563005. > > BUG=344962 > > Committed: https://crrev.com/6ae8c50c839a8c0d8fb399578256c754ed3ce39a > Cr-Commit-Position: refs/heads/master@{#296100} TBR=danakj@chromium.org,jamesr@chromium.org NOTREECHECKS=true NOTRY=true BUG=344962 Committed: https://crrev.com/3bcc3dfc91bc1abb1f141099ac60df1c1f380601 Cr-Commit-Position: refs/heads/master@{#296119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1247 lines) Patch
M cc/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D cc/quads/list_container.h View 1 chunk +0 lines, -179 lines 0 comments Download
D cc/quads/list_container.cc View 1 chunk +0 lines, -592 lines 0 comments Download
D cc/quads/list_container_unittest.cc View 1 chunk +0 lines, -470 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
weiliangc
Created Revert of Class for allocating a chunk of memory for RenderPass
6 years, 3 months ago (2014-09-23 01:18:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595733002/1
6 years, 3 months ago (2014-09-23 01:19:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as f28419a337cc7024ef4671ca955fd271a3d45dd9
6 years, 3 months ago (2014-09-23 01:20:17 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 01:20:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bcc3dfc91bc1abb1f141099ac60df1c1f380601
Cr-Commit-Position: refs/heads/master@{#296119}

Powered by Google App Engine
This is Rietveld 408576698