Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 59573002: Add Frame::isMainFrame and deploy it (Closed)

Created:
7 years, 1 month ago by eseidel
Modified:
7 years, 1 month ago
Reviewers:
dcheng, abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, zoltan1, gavinp+loader_chromium.org, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Add Frame::isMainFrame and deploy it I originally started this to remove Page.h includes but found that it just made the code simpler to read in most cases. In an out of process iframes enabled Blink it will not be possible to access the Page object from core/, so Frame will have to know itself if it is (or thinks it is) the main frame. There are quite a few uses of Page::mainFrame() in core/inspector/ code but it's not obvious that the frame being compared always has the same page as the page its being compared with, so I didn't change those for now. BUG=305811 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -42 lines) Patch
M Source/bindings/v8/V8WindowShell.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/frame/Frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/Frame.cpp View 4 chunks +8 lines, -3 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/ImageDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/loader/HistoryController.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/page/AutoscrollController.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderGeometryMap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eseidel
7 years, 1 month ago (2013-11-05 10:30:20 UTC) #1
abarth-chromium
isMainView -> isMainFrame It looks like you used isMainFrame in the code.
7 years, 1 month ago (2013-11-05 15:57:51 UTC) #2
abarth-chromium
lgtm
7 years, 1 month ago (2013-11-05 15:59:25 UTC) #3
eseidel
Yeah, sorry. Coding at 2am my brain was shot.
7 years, 1 month ago (2013-11-05 18:57:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/59573002/1
7 years, 1 month ago (2013-11-05 18:57:17 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 20:50:05 UTC) #6
Message was sent while issue was closed.
Change committed as 161367

Powered by Google App Engine
This is Rietveld 408576698