Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1825)

Issue 595663002: Put chromoting isolate targets under chromoting_swarm_tests=1 GYP variable. (Closed)

Created:
6 years, 3 months ago by Lei Lei
Modified:
5 years, 6 months ago
Reviewers:
jam, M-A Ruel
CC:
chromium-reviews, anandc, chaitali
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put chromoting isolate targets under chromoting_swarm_tests=1 GYP variable. This avoids the majority of the Chromium builders attempting to build these isolates. BUG= Committed: https://crrev.com/4003c4ff37af38f9dc7176372f3aaddace9cbfd4 Cr-Commit-Position: refs/heads/master@{#296254}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change GYP variable name to archive_chromoting_tests #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+819 lines, -1 line) Patch
M chrome/test/media_router/OWNERS View 1 2 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/media_router/e2e_tests.gyp View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/test/media_router/media_router_base_browsertest.h View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A chrome/test/media_router/media_router_base_browsertest.cc View 1 2 1 chunk +131 lines, -0 lines 0 comments Download
A chrome/test/media_router/media_router_e2e_browsertest.h View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/test/media_router/media_router_e2e_browsertest.cc View 1 2 1 chunk +150 lines, -0 lines 0 comments Download
A chrome/test/media_router/media_router_integration_browsertest.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/test/media_router/media_router_integration_browsertest.cc View 1 2 1 chunk +99 lines, -0 lines 0 comments Download
A chrome/test/media_router/media_router_tests.gypi View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/test/media_router/media_router_tests.isolate View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/test/media_router/resources/basic_test.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/media_router/resources/common.js View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/test/media_router/test_media_sinks_observer.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/test/media_router/test_media_sinks_observer.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Lei Lei
6 years, 3 months ago (2014-09-22 22:11:41 UTC) #2
M-A Ruel
lgtm
6 years, 3 months ago (2014-09-22 22:37:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595663002/1
6 years, 3 months ago (2014-09-23 00:06:17 UTC) #5
jam
lgtm with comment https://codereview.chromium.org/595663002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/595663002/diff/1/build/common.gypi#newcode2371 build/common.gypi:2371: 'chromoting_swarm_tests%': 0, please use the same ...
6 years, 3 months ago (2014-09-23 01:03:32 UTC) #7
Lei Lei
On 2014/09/23 01:03:32, jam wrote: > lgtm with comment > > https://codereview.chromium.org/595663002/diff/1/build/common.gypi > File build/common.gypi ...
6 years, 3 months ago (2014-09-23 03:54:11 UTC) #8
jam
On 2014/09/23 03:54:11, Lei Lei wrote: > On 2014/09/23 01:03:32, jam wrote: > > lgtm ...
6 years, 3 months ago (2014-09-23 05:04:42 UTC) #9
Lei Lei
On 2014/09/23 05:04:42, jam wrote: > On 2014/09/23 03:54:11, Lei Lei wrote: > > On ...
6 years, 3 months ago (2014-09-23 05:08:37 UTC) #10
Lei Lei
On 2014/09/23 05:08:37, Lei Lei wrote: > On 2014/09/23 05:04:42, jam wrote: > > On ...
6 years, 3 months ago (2014-09-23 18:26:55 UTC) #11
Lei Lei
https://codereview.chromium.org/595663002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/595663002/diff/1/build/common.gypi#newcode2371 build/common.gypi:2371: 'chromoting_swarm_tests%': 0, On 2014/09/23 01:03:32, jam wrote: > please ...
6 years, 3 months ago (2014-09-23 18:27:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595663002/20001
6 years, 3 months ago (2014-09-23 20:30:26 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 01ba00cb57087af95c2e3aceb2f4c0819c63b7ea
6 years, 3 months ago (2014-09-23 21:33:29 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 21:34:08 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4003c4ff37af38f9dc7176372f3aaddace9cbfd4
Cr-Commit-Position: refs/heads/master@{#296254}

Powered by Google App Engine
This is Rietveld 408576698