Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 595653003: Roll libvpx 42ddeb:55f7ba (Closed)

Created:
6 years, 3 months ago by Johann
Modified:
6 years, 3 months ago
Reviewers:
Tom Finegan, Wez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll libvpx 42ddeb:55f7ba libvpx roll: https://codereview.chromium.org/592203002 re-instate image compatibility: https://codereview.chromium.org/588403002 Use new VP9E_SET_NOISE_SENSITIVITY introduced in: https://gerrit.chromium.org/gerrit/gitweb?p=webm%2Flibvpx.git;a=commit;h=bb1a23656c63097a4b250ac484b14051f09df9b5 NOTRY=true R=tomfinegan@chromium.org Committed: https://crrev.com/773fd62d4b1657ffc5a24f44c845ede94bc16e7d Cr-Commit-Position: refs/heads/master@{#296285}

Patch Set 1 #

Patch Set 2 : disable compat #

Patch Set 3 : rebase #

Patch Set 4 : VP9E_SET_NOISE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/video_encoder_vpx.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Tom Finegan
lgtm
6 years, 3 months ago (2014-09-23 17:39:10 UTC) #1
Tom Finegan
lgtm
6 years, 3 months ago (2014-09-23 17:39:56 UTC) #2
Johann
Wez, would you please take a look at remoting/codec/video_encoder_vpx.cc Upstream, they have introduced VP*9*E_SET_NOISE_SENSITIVITY
6 years, 3 months ago (2014-09-23 17:43:43 UTC) #4
Wez
LGTM provided that the meaning of parameter value zero hasn't changed. :)
6 years, 3 months ago (2014-09-23 20:39:52 UTC) #5
Johann
On 2014/09/23 20:39:52, Wez wrote: > LGTM provided that the meaning of parameter value zero ...
6 years, 3 months ago (2014-09-23 21:10:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595653003/60001
6 years, 3 months ago (2014-09-23 22:31:45 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 8ce17fac5baab5d29eb2d7950e3c9ea3ff12e669
6 years, 3 months ago (2014-09-23 22:32:50 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 22:35:39 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/773fd62d4b1657ffc5a24f44c845ede94bc16e7d
Cr-Commit-Position: refs/heads/master@{#296285}

Powered by Google App Engine
This is Rietveld 408576698