Port event watcher ChromeVox tests.

Port event watcher ChromeVox tests.

BUG=371692
Committed: https://crrev.com/943d55dbebb385f4bf5aeb12506014753714b0f0
Cr-Commit-Position: refs/heads/master@{#296259}

[dmazzoni, 2014-09-22 19:22:18]

dmazzoni@chromium.org changed reviewers:
+ plundblad@chromium.org

[Peter Lundblad, 2014-09-23 09:40:01]

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js
(right):

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:144:
* Asserts the TTS engine spoken a certain string. Clears the TTS buffer.
nit: grammar seems odd to this non-native speaker.

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:146:
* @return {cvox.TestCaseClass} this.
nit: Type should be ChromeVoxUnitTestBase.

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:186:
* @param {string} eltName The name of the element to focus.
Shouldn't this be the id of the element, not the name?

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:200:
cvox.ChromeVoxUserCommands.commands[command]();
You should add cvox.ChromeVoxUserCommands to the closure dependency list and
make sure all tests that currently set that list append to it (or move the
utility to the test that needs it).

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:207:
spokenList: function() {
This also has an undeclared dependency, but I'd just get rid of this overly
trivial function.

[Peter Lundblad, 2014-09-23 09:46:03]

lgtm

[dmazzoni, 2014-09-23 18:02:41]

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js
(right):

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:144:
* Asserts the TTS engine spoken a certain string. Clears the TTS buffer.
On 2014/09/23 09:40:01, Peter Lundblad wrote:
> nit: grammar seems odd to this non-native speaker.

Done.

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:146:
* @return {cvox.TestCaseClass} this.
On 2014/09/23 09:40:01, Peter Lundblad wrote:
> nit: Type should be ChromeVoxUnitTestBase.

Done.

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:186:
* @param {string} eltName The name of the element to focus.
On 2014/09/23 09:40:01, Peter Lundblad wrote:
> Shouldn't this be the id of the element, not the name?

Done.

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:200:
cvox.ChromeVoxUserCommands.commands[command]();
On 2014/09/23 09:40:00, Peter Lundblad wrote:
> You should add cvox.ChromeVoxUserCommands to the closure dependency list and
> make sure all tests that currently set that list append to it (or move the
> utility to the test that needs it).

Done.

https://codereview.chromium.org/595633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:207:
spokenList: function() {
On 2014/09/23 09:40:00, Peter Lundblad wrote:
> This also has an undeclared dependency, but I'd just get rid of this overly
> trivial function.

It's useful for chaining and will make porting other tests easier, so I'd prefer
to leave it and fix the dependency.

[dmazzoni, 2014-09-23 18:22:48]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-09-23 18:33:57]

The CQ bit was unchecked by dmazzoni@chromium.org

[dmazzoni, 2014-09-23 18:52:21]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-09-23 20:31:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595633002/40001

[commit-bot: I haz the power, 2014-09-23 21:41:35]

Committed patchset #3 (id:40001) as 66119ceaf17f49066e916f1c1f33b487b6d2da4a

[commit-bot: I haz the power, 2014-09-23 21:42:22]

Patchset 3 (id:??) landed as
https://crrev.com/943d55dbebb385f4bf5aeb12506014753714b0f0
Cr-Commit-Position: refs/heads/master@{#296259}