Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 595603002: Cleanup RenderTreeAsText (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup RenderTreeAsText Cleanup RenderTreeAsText as well as SVGRenderTreeAsText: - fix outdated comment - remove unused methods - share stream insertion operator for Color BUG=416453 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -49 lines) Patch
M Source/core/rendering/RenderTreeAsText.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 6 chunks +13 lines, -12 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.h View 3 chunks +0 lines, -31 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rwlbuis
PTAL. Btw we could also move more stuff from SVGRenderTreeAsText.h into RenderTreeAsText and remove it.
6 years, 3 months ago (2014-09-22 19:44:53 UTC) #2
dsinclair
lgtm
6 years, 3 months ago (2014-09-22 20:15:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595603002/1
6 years, 3 months ago (2014-09-22 21:46:15 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 22:43:33 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 182452

Powered by Google App Engine
This is Rietveld 408576698