Splitting of layers for correct intersections

cc/output/dynamic_geometry_binding.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_OUTPUT_DYNAMIC_GEOMETRY_BINDING_H_
+#define CC_OUTPUT_DYNAMIC_GEOMETRY_BINDING_H_
+
+#include "cc/output/geometry_binding.h"
+
+using gpu::gles2::GLES2Interface;

[enne (OOO), 2015/02/12 18:00:26]

style nit: don't use "using" in a header.

[awoloszyn, 2015/02/23 22:28:26]

Done.

+
+namespace cc {
+
+class DynamicGeometryBinding {
+ public:
+  explicit DynamicGeometryBinding(gpu::gles2::GLES2Interface* gl);
+  void PrepareForDraw();
+  void InitializeCustomQuad(const gfx::QuadF& quad);
+  void InitializeCustomQuadWithUVs(const gfx::QuadF& quad, const float* uv);

[enne (OOO), 2015/02/12 18:00:26]

Can you make this const float uv[8], to be better documented?

[enne (OOO), 2015/02/12 18:00:26]

Can you make this const float uv[8], to be better documented?

+
+ private:
+  gpu::gles2::GLES2Interface* gl_;
+
+  GLuint quad_vertices_vbo_;
+  GLuint quad_elements_vbo_;
+  DISALLOW_COPY_AND_ASSIGN(DynamicGeometryBinding);

[enne (OOO), 2015/02/12 18:00:26]

style nit: blank line before DISALLOW

[awoloszyn, 2015/02/23 22:28:26]

Done.

+};
+
+}  // namespace cc
+
+#endif  // CC_OUTPUT_DYNAMIC_GEOMETRY_BINDING_H_