Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 595543003: Don't return unfound VS version, raise instead (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
Timur Iskhodzhanov
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Don't return unfound VS version, raise instead This fallback behaviour may have worked at some point, but doesn't any more, so simply error out with a clear message rather than trying to continue. R=timurrrr@chromium.org BUG=https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/O_OGfq2nhSw Committed: https://code.google.com/p/gyp/source/detail?r=1978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M pylib/gyp/MSVSVersion.py View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scottmg
6 years, 3 months ago (2014-09-22 16:16:56 UTC) #1
Timur Iskhodzhanov
lgtm
6 years, 3 months ago (2014-09-23 14:02:46 UTC) #2
scottmg
6 years, 3 months ago (2014-09-23 16:21:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698