Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 595513002: Further improve deopt reason output. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Further improve deopt reason output. * Make the detailed deopt reason mandatory on x64, other platforms will follow in separate CLs. * Extracted and improved jump table entry sharing logic: When --trace-deopt is on, we get separate entries for different deopt reasons. This enables us to distinguish the several reasons single instructions can have. * Don't emit superfluous jump table comments: The bailout ID is still visible, and the jump table entry number is not interesting (but easy to determine if really needed). * Unify the internal name of the jump table member across platforms. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -179 lines) Patch
M src/arm/lithium-codegen-arm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +12 lines, -18 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M src/deoptimizer.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +11 lines, -17 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +9 lines, -15 lines 0 comments Download
M src/utils.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 72 chunks +91 lines, -97 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sven Panne
6 years, 3 months ago (2014-09-22 13:32:05 UTC) #2
Jarin
lgtm. I like where this is going. However, I am not too happy about using ...
6 years, 3 months ago (2014-09-22 14:04:38 UTC) #3
Sven Panne
On 2014/09/22 14:04:38, jarin wrote: > lgtm. I like where this is going. > > ...
6 years, 3 months ago (2014-09-22 14:16:05 UTC) #4
Sven Panne
6 years, 3 months ago (2014-09-22 14:17:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24123 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698