Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 595493002: Roll breakpad r1375 -> r1384. (Closed)

Created:
6 years, 3 months ago by simonb (inactive)
Modified:
6 years, 3 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll breakpad r1375 -> r1384. r1384 Fix clang compilation error introduced in r1380. r1381 Add inttypes for windows in dump_context r1380 Extend mapping merge to include reserved but unused mappings. r1379 GoogleCrashdumpUploader: adds Upload(string*) API to get the HTTP response. r1378 Fixes common_unittests build. r1377 Fix Windows client unittests build: add missing code files r1376 Making the Mac build of crash_report work again after the last SVN sync BUG=394703 Committed: https://crrev.com/9eea518bf3c86e25535190995e9243e4ee34fb4a Cr-Commit-Position: refs/heads/master@{#296163}

Patch Set 1 #

Patch Set 2 : Include r1384, rebase to master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
simonb (inactive)
6 years, 3 months ago (2014-09-22 13:28:35 UTC) #2
rmcilroy
LGTM.
6 years, 3 months ago (2014-09-22 13:47:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595493002/1
6 years, 3 months ago (2014-09-22 13:54:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/1002)
6 years, 3 months ago (2014-09-22 14:05:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595493002/20001
6 years, 3 months ago (2014-09-22 17:18:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/17756)
6 years, 3 months ago (2014-09-22 17:54:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595493002/20001
6 years, 3 months ago (2014-09-23 09:52:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a49bae324f78312f393dd213a836ee0e02813121
6 years, 3 months ago (2014-09-23 10:03:36 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 10:04:11 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9eea518bf3c86e25535190995e9243e4ee34fb4a
Cr-Commit-Position: refs/heads/master@{#296163}

Powered by Google App Engine
This is Rietveld 408576698