Issue 595453002: Pass the ast_id to HandleKeyed to make sure it's the right one (e.g., CountOperation, not just the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 595453002: Pass the ast_id to HandleKeyed to make sure it's the right one (e.g., CountOperation, not just the … (Closed)

Created:
6 years, 3 months ago by Toon Verwaest

Modified:
6 years, 3 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Pass the ast_id to HandleKeyed to make sure it's the right one (e.g., CountOperation, not just the load-expression's id) BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24117

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -5 lines)			Patch
M	src/hydrogen.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/mjsunit/keyed-named-access.js	View	1 chunk	+36 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Toon Verwaest

6 years, 3 months ago (2014-09-22 12:43:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24117 (presubmit successful).