Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 595413002: Draw an accessibility focus ring around the focused object in ChromeVox Next. (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, kalyank, sadrul, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, ben+ash_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Draw an accessibility focus ring around the focused object in ChromeVox Next. BUG=314889 Committed: https://crrev.com/2d50f5cb9c9e6adba711be342feb52ddb6f0250d Cr-Commit-Position: refs/heads/master@{#296773}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix compile #

Patch Set 3 : Fix automation browser test #

Messages

Total messages: 13 (4 generated)
dmazzoni
6 years, 2 months ago (2014-09-24 18:44:35 UTC) #2
David Tseng
https://codereview.chromium.org/595413002/diff/1/chrome/browser/extensions/api/automation_internal/automation_util.h File chrome/browser/extensions/api/automation_internal/automation_util.h (right): https://codereview.chromium.org/595413002/diff/1/chrome/browser/extensions/api/automation_internal/automation_util.h#newcode31 chrome/browser/extensions/api/automation_internal/automation_util.h:31: const gfx::Vector2d& location_offset); I don't see any changes for ...
6 years, 2 months ago (2014-09-24 19:28:15 UTC) #3
dmazzoni
https://codereview.chromium.org/595413002/diff/1/chrome/browser/extensions/api/automation_internal/automation_util.h File chrome/browser/extensions/api/automation_internal/automation_util.h (right): https://codereview.chromium.org/595413002/diff/1/chrome/browser/extensions/api/automation_internal/automation_util.h#newcode31 chrome/browser/extensions/api/automation_internal/automation_util.h:31: const gfx::Vector2d& location_offset); On 2014/09/24 19:28:15, David Tseng wrote: ...
6 years, 2 months ago (2014-09-24 19:36:08 UTC) #4
David Tseng
lgtm
6 years, 2 months ago (2014-09-24 19:41:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595413002/20001
6 years, 2 months ago (2014-09-24 21:50:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/51212)
6 years, 2 months ago (2014-09-24 22:52:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595413002/40001
6 years, 2 months ago (2014-09-25 18:40:06 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 9b6bb4021c80b6a852e052e1963e5fdca89d88ff
6 years, 2 months ago (2014-09-25 19:56:56 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 19:57:46 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/2d50f5cb9c9e6adba711be342feb52ddb6f0250d
Cr-Commit-Position: refs/heads/master@{#296773}

Powered by Google App Engine
This is Rietveld 408576698