Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 595383002: cros: Fix external cache not updating. (Closed)

Created:
6 years, 3 months ago by xiyuan
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Dmitry Polukhin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cros: Fix external cache not updating. ExtensionDownloader should be created via its factory so that all parameters needed by the ping URL would be filled out properly. BUG=416648 Committed: https://crrev.com/f35425b2de4b7a08b84dc0745579d6964a3c8a0b Cr-Commit-Position: refs/heads/master@{#296477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/external_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xiyuan
6 years, 3 months ago (2014-09-24 17:44:52 UTC) #2
tbarzic
lgtm
6 years, 3 months ago (2014-09-24 18:15:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595383002/1
6 years, 3 months ago (2014-09-24 18:22:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 48fb50bd60c8296bcc0fa57c08241b4136c6837b
6 years, 3 months ago (2014-09-24 18:46:48 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f35425b2de4b7a08b84dc0745579d6964a3c8a0b Cr-Commit-Position: refs/heads/master@{#296477}
6 years, 3 months ago (2014-09-24 18:47:53 UTC) #7
Dmitry Polukhin
6 years, 3 months ago (2014-09-25 06:36:08 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698