Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 595363002: Add policy controlled permission block list for extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ext-fix
Patch Set: fix memory leaks Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 7636dfe7101bd3f8bead57445336aa37760f9fe9..76ac9a2105c1d6f7e689a716ddfb33236fba9e0f 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1709,6 +1709,23 @@ void ExtensionService::OnExtensionInstalled(
void ExtensionService::OnExtensionManagementSettingsChanged() {
error_controller_->ShowErrorIfNeeded();
+
+ // Revokes blocked permissions from active_permissions for all extensions.
+ extensions::ExtensionManagement* settings =
+ extensions::ExtensionManagementFactory::GetForBrowserContext(profile());
+ CHECK(settings);
+ scoped_ptr<ExtensionSet> all_extensions(
+ registry_->GenerateInstalledExtensionsSet());
+ for (const auto& extension : *all_extensions.get()) {
+ if (!settings->IsPermissionSetAllowed(
+ extension->id(),
+ extension->permissions_data()->active_permissions())) {
+ extensions::PermissionsUpdater(profile()).RemovePermissions(
+ extension.get(),
+ settings->GetBlockedPermissions(extension->id()).get());
+ }
+ }
+
CheckManagementPolicy();
}
« no previous file with comments | « chrome/browser/extensions/extension_management_unittest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698