Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 595353003: [Password Generation] Small UI tweaks (Closed)

Created:
6 years, 3 months ago by Garrett Casto
Modified:
6 years, 2 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Small UI tweaks BUG=412955 Committed: https://crrev.com/10f088f2d2fccc421ce5524113a7203f4923874c Cr-Commit-Position: refs/heads/master@{#296550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/autofill/password_generation_popup_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Garrett Casto
6 years, 3 months ago (2014-09-24 18:32:21 UTC) #2
Evan Stade
lgtm
6 years, 3 months ago (2014-09-24 21:45:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595353003/1
6 years, 3 months ago (2014-09-24 22:01:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f2bf25e67c3767bc1180488c772ad53e148aa4c6
6 years, 3 months ago (2014-09-24 22:59:50 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/10f088f2d2fccc421ce5524113a7203f4923874c Cr-Commit-Position: refs/heads/master@{#296550}
6 years, 3 months ago (2014-09-24 23:00:29 UTC) #7
Thiemo Nagel
6 years, 2 months ago (2014-09-25 08:18:47 UTC) #8
Message was sent while issue was closed. 
Hi Garrett, 

are you sure the bug number is correct?

Cheers,
Thiemo

Powered by Google App Engine
This is Rietveld 408576698