Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 595353002: Revert of Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (Closed)

Created:
6 years, 3 months ago by jiayl
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Mads Ager (chromium), pdr., wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/601803002/) Reason for revert: Wrong revert. I misread the buildbot failure email. Original issue's description: > Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/595313002/) > > Reason for revert: > Break build: > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/19333 > > Original issue's description: > > Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) > > > > Summary of changes available at: > > https://chromium.googlesource.com/chromium/blink/+log/f2b7b089..5fa19f3 > > > > TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org > > > > Committed: https://crrev.com/0ae73de143b645c376ac0e503e9627d33bb3c4f1 > > Cr-Commit-Position: refs/heads/master@{#296414} > > TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/677a9222f8fbf4e581ba4461ae700c8c380bc78c > Cr-Commit-Position: refs/heads/master@{#296418} TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b64c9661d139f6ab1e2a1e0b3e1052251acafa7f Cr-Commit-Position: refs/heads/master@{#296426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jiayl
Created Revert of Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594)
6 years, 3 months ago (2014-09-24 15:52:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595353002/1
6 years, 3 months ago (2014-09-24 15:52:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 84f0b9d9b4973f4abed1e127fd21bf2bf5847703
6 years, 3 months ago (2014-09-24 15:52:57 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 15:53:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b64c9661d139f6ab1e2a1e0b3e1052251acafa7f
Cr-Commit-Position: refs/heads/master@{#296426}

Powered by Google App Engine
This is Rietveld 408576698