Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 595343003: Revert of Roll breakpad a513e85:7caf028 (svn 1384:1385) (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll breakpad a513e85:7caf028 (svn 1384:1385) (patchset #1 id:1 of https://codereview.chromium.org/590403003/) Reason for revert: Broke TSANv2 builder: breakpad/src/client/linux/minidump_writer/minidump_writer.cc:554:37: error: use of undeclared identifier 'time' header.get()->time_date_stamp = time(NULL); Original issue's description: > Roll breakpad a513e85:7caf028 (svn 1384:1385) > > r1385: Linux: Call memset() in a couple places in ExceptionHandler. > > BUG=332335 > > Committed: https://crrev.com/ec86bac94da60dc9286bb49b87745570a83a6a55 > Cr-Commit-Position: refs/heads/master@{#296446} TBR=timurrrr@chromium.org NOTREECHECKS=true NOTRY=true BUG=332335 Committed: https://crrev.com/20676054ca30162420e12108170d75596c672486 Cr-Commit-Position: refs/heads/master@{#296459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
Created Revert of Roll breakpad a513e85:7caf028 (svn 1384:1385)
6 years, 3 months ago (2014-09-24 17:56:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595343003/1
6 years, 3 months ago (2014-09-24 17:56:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0d495e388fbd574a125322986e4f46b10a2e29c0
6 years, 3 months ago (2014-09-24 17:57:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/20676054ca30162420e12108170d75596c672486 Cr-Commit-Position: refs/heads/master@{#296459}
6 years, 3 months ago (2014-09-24 17:58:54 UTC) #4
Timur Iskhodzhanov
6 years, 2 months ago (2014-09-25 14:43:55 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698