Issue 595333002: Non-JSArrays must always have holey elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 595333002: Non-JSArrays must always have holey elements. (Closed)

Created:
6 years, 3 months ago by Jakob Kummerow

Modified:
6 years, 2 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Non-JSArrays must always have holey elements. Drive-by cleanup: remove unused elements_kind_ field in CallNew. BUG=chromium:416558 LOG=n R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24211

Patch Set 2 : use CHECK_EQ #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -9 lines)			Patch
M	src/ast.h	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	src/ast.cc	View		1 chunk	+0 lines, -3 lines	1 comment	Download
M	src/factory.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/objects-debug.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-crbug-416558.js	View		1 chunk	+115 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Right on, LGTM. https://codereview.chromium.org/595333002/diff/20001/src/ast.cc File src/ast.cc (left): https://codereview.chromium.org/595333002/diff/20001/src/ast.cc#oldcode618 src/ast.cc:618: if (!allocation_site_.is_null()) { ah, thanks!

6 years, 3 months ago (2014-09-24 15:13:52 UTC) #2

Jakob Kummerow

6 years, 2 months ago (2014-09-25 08:25:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24211 (presubmit successful).

Expand Messages | Collapse Messages

Issue 595333002: Non-JSArrays must always have holey elements. (Closed)

Description

Patch Set 1 #

Patch Set 2 : use CHECK_EQ #

Messages