content/public/android/java/src/org/chromium/content/app/ChildProcessService.java - Issue 59533009: Check library version and handle library load errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/app/ChildProcessService.java

Issue 59533009: Check library version and handle library load errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Answer review comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/app/android/library_loader_hooks.cc ('K') | « content/app/android/library_loader_hooks.cc ('k') | content/public/android/java/src/org/chromium/content/app/LibraryLoader.java » ('j') | content/public/android/java/src/org/chromium/content/app/LibraryLoader.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/app/ChildProcessService.java

diff --git a/content/public/android/java/src/org/chromium/content/app/ChildProcessService.java b/content/public/android/java/src/org/chromium/content/app/ChildProcessService.java

index d5ab06d4fe56c84cd80be76133e1ffd986d1faaf..2c36127976c2dcf834530a70a4fd77b1982fa7af 100644

--- a/content/public/android/java/src/org/chromium/content/app/ChildProcessService.java

+++ b/content/public/android/java/src/org/chromium/content/app/ChildProcessService.java

@@ -141,7 +141,7 @@ public class ChildProcessService extends Service {

LibraryLoader.loadNow();

} catch (ProcessInitException e) {

Log.e(TAG, "Failed to load native library, exiting child process", e);

- return;

+ System.exit(-1);

Yaron 2013/11/16 00:10:26 What happens in this case? if somehow the browser

aberent 2013/11/18 15:11:37 Yes.

}

synchronized (mMainThread) {

while (mCommandLineParams == null) {