Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

Issue 59533009: Check library version and handle library load errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java b/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
index c0657a3b0e3da4658e86608042657cbbdc761d4e..3c80effafddee841851b74484330bdab348667ae 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
@@ -45,9 +45,13 @@ public abstract class AwBrowserProcess {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- if( !BrowserStartupController.get(context).startBrowserProcessesSync(
- BrowserStartupController.MAX_RENDERERS_SINGLE_PROCESS)) {
- throw new RuntimeException("Cannot initialize WebView");
+ try {
+ if( !BrowserStartupController.get(context).startBrowserProcessesSync(
joth 2013/11/11 20:28:56 this is a bit tricky now - it can return an error
Yaron 2013/11/12 02:58:18 Ya, I tend to agree with joth
aberent 2013/11/13 20:20:52 Done.
+ BrowserStartupController.MAX_RENDERERS_SINGLE_PROCESS)) {
+ throw new RuntimeException("Cannot initialize WebView");
+ }
+ } catch (ProcessInitException e) {
+ throw new RuntimeException("Cannot initialize WebView", e);
}
}
});

Powered by Google App Engine
This is Rietveld 408576698