content/public/android/java/templates/native_libraries_array.h - Issue 59533009: Check library version and handle library load errors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/templates/native_libraries_array.h

Issue 59533009: Check library version and handle library load errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to second round of review comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/android/java/src/org/chromium/content/app/LibraryLoader.java ('K') | « content/public/android/java/templates/NativeLibraries.template ('k') | content/public/android/java/templates/native_libraries_version.h » ('j') | content/public/app/android_library_loader_hooks.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This is a placeholder for compiling content_java. The content java library	5 // This is a placeholder for compiling content_java. The content java library

6 // is compiled with no array defined, and then the build system creates a	6 // is compiled with no array defined, and then the build system creates a

7 // version of the file with the real list of libraries required (which changes	7 // version of the file with the real list of libraries required (which changes

8 // based upon which .apk is being built).	8 // based upon which .apk is being built).

	9 ={}
	joth 2013/11/18 19:45:23 wowzers, this is the strangest pair of header file wowzers, this is the strangest pair of header files I did see. but, i guess, it's OK. The comment could explain the context this is used in? (variable name prefix, semi-colon postfix) Hmmmm this is only ever #included from java. Does it need to be a .h file at all? aberent 2013/11/25 18:31:47 I have added to the comment. The change goes with Show quoted text On 2013/11/18 19:45:23, joth wrote: > wowzers, this is the strangest pair of header files I did see. > > but, i guess, it's OK. The comment could explain the context this is used in? > (variable name prefix, semi-colon postfix) I have added to the comment. The change goes with making LIBRARIES final in NativeLibraries.template, which means that it has to be given a value when it is declared. Show quoted text > > Hmmmm this is only ever #included from java. Does it need to be a .h file at > all? No, but it seems to be the convention we are following for all files included by the C preprocessor, whatever the final language of the resulting code.
OLD	NEW