android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java - Issue 59533009: Check library version and handle library load errors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java

Issue 59533009: Check library version and handle library load errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java » ('j') | android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.content.app;	5 package org.chromium.content.app;

6	6

7 public class NativeLibraries {	7 public class NativeLibraries {

8 // Set to true to use the content linker. Only useful to save memory	8 // Set to true to use the content linker. Only useful to save memory

9 // on multi-process content-based projects. Always disabled for the Android Webview.	9 // on multi-process content-based projects. Always disabled for the Android Webview.

10 public static boolean USE_LINKER = false;	10 public static boolean USE_LINKER = false;

11	11

12 // Set to true to enable content linker test support. NEVER enable this for the	12 // Set to true to enable content linker test support. NEVER enable this for the

13 // Android webview.	13 // Android webview.

14 public static boolean ENABLE_LINKER_TESTS = false;	14 public static boolean ENABLE_LINKER_TESTS = false;

15	15

16 // This is the list of native libraries to load. In the normal chromium buil d, this would be	16 // This is the list of native libraries to load. In the normal chromium buil d, this would be

17 // automatically generated.	17 // automatically generated.

18 // TODO(torne, cjhopman): Use a generated file for this.	18 // TODO(torne, cjhopman): Use a generated file for this.

19 static String[] libraries = { "webviewchromium" };	19 static String[] libraries = { "webviewchromium" };

	20 // There is currently no check for the C++ library version in WebView.

	21 static String versionName = "";
	joth 2013/11/11 20:28:56 nit: sVersionName (and libraries should be too) o nit: sVersionName (and libraries should be too) oh, or does the TODO cover both of them? (can the be static final? in which case LIBRARIES and VERSION_NAME would be better) aberent 2013/11/13 20:20:52 I have changed the names to constant names, but I Show quoted text On 2013/11/11 20:28:56, joth wrote: > nit: sVersionName (and libraries should be too) > > oh, or does the TODO cover both of them? > > (can the be static final? in which case LIBRARIES and VERSION_NAME would be > better) I have changed the names to constant names, but I can't actually make VERSION_NAME (now VERSION_NUMBER, based on a later comment) static final here or in the NativeLibraries.Template because that makes it a compile time constant. This breaks with our current build system, which replaces NativeLibraries.class based on the product being built. I will also add a TODO to the second comment, since what is to do is slightly different from the first case.
20 }	22 }

OLD	NEW