chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm - Issue 595283002: Move nsview_additions and hyperlink_text_view to ui/base/cocoa

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

Issue 595283002: Move nsview_additions and hyperlink_text_view to ui/base/cocoa (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

index de262811be41ba991987899c6f0bcfa89115dd13..0b52383a314b3019b8703bb7b3bcdd6dd336a230 100644

--- a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

@@ -15,7 +15,6 @@

#include "chrome/browser/ui/browser_commands.h"

#import "chrome/browser/ui/cocoa/browser_window_controller.h"

#import "chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.h"

-#import "chrome/browser/ui/cocoa/hyperlink_text_view.h"

#import "chrome/browser/ui/cocoa/info_bubble_view.h"

#import "chrome/browser/ui/cocoa/info_bubble_window.h"

#include "chrome/browser/ui/fullscreen/fullscreen_controller.h"

@@ -26,6 +25,7 @@

#include "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"

#import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"

#include "ui/base/accelerators/platform_accelerator_cocoa.h"

+#import "ui/base/cocoa/controls/hyperlink_text_view.h"

Dan Beam 2014/09/25 19:03:51 it seems this might've broken some print preview F

groby-ooo-7-16 2014/09/25 19:28:36 Yes - symbols you want available outside ui/base n

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/l10n/l10n_util_mac.h"

#include "ui/strings/grit/ui_strings.h"

« no previous file with comments | « chrome/browser/ui/cocoa/framed_browser_window.mm ('k') | chrome/browser/ui/cocoa/gradient_button_cell.mm » ('j') | no next file with comments »