Move nsview_additions and hyperlink_text_view to ui/base/cocoa

Move nsview_additions and hyperlink_text_view to ui/base/cocoa

BUG=402485
TBR=thakis@chrmoium.org for chrome_nibs.gyp

Committed: https://crrev.com/0e6cd43eb9a467c81382e37f686f3ebfdda5c1d3
Cr-Commit-Position: refs/heads/master@{#296651}

[hashimoto, 2014-09-24 09:57:15]

hashimoto@chromium.org changed reviewers:
+ avi@chromium.org

[hashimoto, 2014-09-24 09:57:16]

avi@, could you review this change?

These files should be moved out of chrome/ to componentize SadTab code
(https://codereview.chromium.org/543663002/).

[Avi (use Gerrit), 2014-09-24 15:36:27]

LGTM!

[tfarina, 2014-09-24 16:25:18]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2014-09-24 16:25:19]

lgtm

ui/base/ui_base.gyp and ui/base/ui_base_tests.gypi changes lgtm.

[hashimoto, 2014-09-25 03:58:40]

hashimoto@chromium.org changed reviewers:
+ thakis@chromium.org

[hashimoto, 2014-09-25 03:59:11]

TBRing thakis@chrmoium.org for chrome_nibs.gyp

[hashimoto, 2014-09-25 03:59:31]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-09-25 04:00:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595283002/20001

[commit-bot: I haz the power, 2014-09-25 04:09:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-25 04:10:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hashimoto, 2014-09-25 04:16:08]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-09-25 04:17:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595283002/40001

[commit-bot: I haz the power, 2014-09-25 05:07:18]

Committed patchset #3 (id:40001) as 2b797aa65c83a5959afceb72237d1f8178712211

[commit-bot: I haz the power, 2014-09-25 05:08:04]

Patchset 3 (id:??) landed as
https://crrev.com/0e6cd43eb9a467c81382e37f686f3ebfdda5c1d3
Cr-Commit-Position: refs/heads/master@{#296651}

[Dan Beam, 2014-09-25 19:03:50]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2014-09-25 19:03:52]

cc: ivandavid, thestig, groby

https://codereview.chromium.org/595283002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm (right):

https://codereview.chromium.org/595283002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm:28: #import
"ui/base/cocoa/controls/hyperlink_text_view.h"
it seems this might've broken some print preview FYI bots:
http://build.chromium.org/p/chromium.fyi/builders/Print%20Preview%20Mac/build...

any ideas how to fix?  export some symbol, perhaps?  (just looks like a missing
symbol when linking)

[Dan Beam, 2014-09-25 19:04:00]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[groby-ooo-7-16, 2014-09-25 19:28:35]

groby@chromium.org changed reviewers:
+ groby@chromium.org

[groby-ooo-7-16, 2014-09-25 19:28:37]

What drives the need to move this to ui/base?

https://codereview.chromium.org/595283002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm (right):

https://codereview.chromium.org/595283002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm:28: #import
"ui/base/cocoa/controls/hyperlink_text_view.h"
On 2014/09/25 19:03:51, Dan Beam wrote:
> it seems this might've broken some print preview FYI bots:
>
http://build.chromium.org/p/chromium.fyi/builders/Print%20Preview%20Mac/build...
> 
> any ideas how to fix?  export some symbol, perhaps?  (just looks like a
missing
> symbol when linking)

Yes - symbols you want available outside ui/base need to be marked
UI_BASE_EXPORT

[Avi (use Gerrit), 2014-09-25 19:34:32]

This is being fixed in https://codereview.chromium.org/602093004/, CQed just
now.

[tfarina, 2014-09-25 19:54:23]

On Thu, Sep 25, 2014 at 4:28 PM, <groby@chromium.org> wrote:

> What drives the need to move this to ui/base?
>
> I think it is because sad tab that currently lives in chrome/ is going to
be moved into components/. That is what is driving this.

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hashimoto, 2014-09-26 04:34:56]

Oops, I was relying too much on CQ so expected it to catch this kind of error.
Sorry for the mess and thank you for fixing it.