Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 595273003: [SyncFS] Clean up SequencedWorkerPool in SyncEngineTest (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Clean up SequencedWorkerPool in SyncEngineTest BUG=None Committed: https://crrev.com/0c5492996c545eb19407b5bdb88ed05630afb582 Cr-Commit-Position: refs/heads/master@{#296376}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tzik
PTL. This seems to cause a leak of SequencedWorkerPool.
6 years, 3 months ago (2014-09-24 09:08:03 UTC) #2
nhiroki
lgtm
6 years, 3 months ago (2014-09-24 09:20:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595273003/20001
6 years, 3 months ago (2014-09-24 09:22:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 52767428cc5c4276ea78a224f309ec990752ef2f
6 years, 3 months ago (2014-09-24 09:51:44 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 09:52:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c5492996c545eb19407b5bdb88ed05630afb582
Cr-Commit-Position: refs/heads/master@{#296376}

Powered by Google App Engine
This is Rietveld 408576698