Issue 595253002: Simplify stack trace getter wrt prototype chain walk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 595253002: Simplify stack trace getter wrt prototype chain walk. (Closed)

Created:
6 years, 3 months ago by Yang

Modified:
6 years, 3 months ago

Reviewers:
Dmitry Lomov (no reviews), arv (Not doing code reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Simplify stack trace getter wrt prototype chain walk. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24170

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
	M	src/messages.js	View		1 chunk	+17 lines, -15 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Yang

Committed patchset #1 (id:1) manually as 24170 (presubmit successful).

6 years, 3 months ago (2014-09-24 08:39:12 UTC) #3

arv (Not doing code reviews)

6 years, 3 months ago (2014-09-24 14:15:17 UTC) #5

Message was sent while issue was closed.

FYI

https://codereview.chromium.org/595253002/diff/1/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/595253002/diff/1/src/messages.js#newcode1128
src/messages.js:1128: GET_PRIVATE(holder, formatted_stack_trace_symbol);
wrong indent

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages