Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3884)

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 595213005: Eliminate chrome::IsTrustedWindowWithScheme (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index 093889d53e32b7b285fd092b23b444449f7c35a7..78e308f7779b2273d221af4b7593f1d268a71104 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -207,20 +207,6 @@ GURL GetSettingsUrl(const std::string& sub_page) {
return GURL(url);
}
-bool IsTrustedPopupWindowWithScheme(const Browser* browser,
- const std::string& scheme) {
- if (!browser->is_type_popup() || !browser->is_trusted_source())
- return false;
- if (scheme.empty()) // Any trusted popup window
- return true;
- const content::WebContents* web_contents =
- browser->tab_strip_model()->GetWebContentsAt(0);
- if (!web_contents)
- return false;
- GURL url(web_contents->GetURL());
- return url.SchemeIs(scheme.c_str());
-}
-
void ShowSettings(Browser* browser) {
ShowSettingsSubPage(browser, std::string());
}

Powered by Google App Engine
This is Rietveld 408576698