Eliminate chrome::IsTrustedWindowWithScheme

chrome/browser/ui/settings_window_manager.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/settings_window_manager.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_navigator.h"
@@ skipping 36 matching lines @@
     }
     NavigateParams params(browser, gurl,
                           ui::PAGE_TRANSITION_AUTO_BOOKMARK);
     params.window_action = NavigateParams::SHOW_WINDOW;
     params.user_gesture = true;
     chrome::Navigate(&params);
     return;
   }
 
   // No existing browser window, create one.
-  NavigateParams params(profile, gurl, ui::PAGE_TRANSITION_AUTO_BOOKMARK);
-  params.disposition = NEW_POPUP;
-  params.trusted_source = true;
-  params.window_action = NavigateParams::SHOW_WINDOW;
-  params.user_gesture = true;
-  params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE;
-  chrome::Navigate(&params);
-  settings_session_map_[profile] = params.browser->session_id().id();
+  navigate_params_.reset(
+      new NavigateParams(profile, gurl, ui::PAGE_TRANSITION_AUTO_BOOKMARK));
+  navigate_params_->disposition = NEW_POPUP;
+  navigate_params_->trusted_source = true;
+  navigate_params_->window_action = NavigateParams::SHOW_WINDOW;
+  navigate_params_->user_gesture = true;
+  navigate_params_->path_behavior = NavigateParams::IGNORE_AND_NAVIGATE;
+  chrome::Navigate(navigate_params_.get());
+  settings_session_map_[profile] = navigate_params_->browser->session_id().id();
+  // Once we set settings_session_map_, reset |navigate_params_| so that we do
+  // not hold on to a structure with stale pointers.
+  navigate_params_.reset();
 
   FOR_EACH_OBSERVER(SettingsWindowManagerObserver,
-                    observers_, OnNewSettingsWindow(params.browser));
+                    observers_, OnNewSettingsWindow(navigate_params_->browser));
 }
 
 Browser* SettingsWindowManager::FindBrowserForProfile(Profile* profile) {
   ProfileSessionMap::iterator iter = settings_session_map_.find(profile);
   if (iter != settings_session_map_.end())
     return chrome::FindBrowserWithID(iter->second);
   return NULL;
 }
 
 bool SettingsWindowManager::IsSettingsBrowser(Browser* browser) const {
+  // This may get called from chrome::Navigate, so first test to see if this
+  // is the browser we are crrently navigating to.
+  if (navigate_params_ && navigate_params_->browser == browser)

[sky, 2014/09/25 23:36:52]

Dependencies like this are fragile and result in NavigateParams needing to talk
to more things. I would rather you add something to NavigateParams that
explicitly tells it the browser is a settings browser.

+    return true;
   ProfileSessionMap::const_iterator iter =
       settings_session_map_.find(browser->profile());
   return (iter != settings_session_map_.end() &&
           iter->second == browser->session_id().id());
 }
 
 SettingsWindowManager::SettingsWindowManager() {
 }
 
 SettingsWindowManager::~SettingsWindowManager() {
 }
 
 }  // namespace chrome