tools/telemetry/telemetry/core/webpagereplay.py - Issue 595213003: Handle the Web Page Replay related Chrome flags in one place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/webpagereplay.py

Issue 595213003: Handle the Web Page Replay related Chrome flags in one place. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend_unittest.py ('k') | tools/telemetry/telemetry/core/wpr_server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/webpagereplay.py

diff --git a/tools/telemetry/telemetry/core/webpagereplay.py b/tools/telemetry/telemetry/core/webpagereplay.py

index 5b45ff654abb69ecbcafbe088a7c628873d50ad6..4088d32ca4b11b72a85cf7aff142f734aa989eed 100644

--- a/tools/telemetry/telemetry/core/webpagereplay.py

+++ b/tools/telemetry/telemetry/core/webpagereplay.py

@@ -26,17 +26,6 @@ LOG_PATH = os.path.join(

_CHROME_SRC_DIR, 'webpagereplay_logs', 'logs.txt')

-# Chrome options to make it work with Web Page Replay.

-def GetChromeFlags(replay_host, http_port, https_port):

- assert replay_host and http_port and https_port, 'All arguments required'

- return [

- '--host-resolver-rules=MAP * %s,EXCLUDE localhost' % replay_host,

- '--testing-fixed-http-port=%s' % http_port,

- '--testing-fixed-https-port=%s' % https_port,

- '--ignore-certificate-errors',

- ]

# Signal masks on Linux are inherited from parent processes. If anything

# invoking us accidentally masks SIGINT (e.g. by putting a process in the

# background from a shell script), sending a SIGINT to the child will fail