tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py - Issue 595213003: Handle the Web Page Replay related Chrome flags in one place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 595213003: Handle the Web Page Replay related Chrome flags in one place. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

index 401b7b926d9add1e35b38a9828f7be7b72aaa257..7d69a53e7a906e4a2be53e765b6fd10723395adc 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

@@ -327,9 +327,6 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

def GetBrowserStartupArgs(self):

args = super(AndroidBrowserBackend, self).GetBrowserStartupArgs()

- if self.forwarder_factory.does_forwarder_override_dns:

- args = [arg for arg in args

- if not arg.startswith('--host-resolver-rules')]

args.append('--enable-remote-debugging')

args.append('--disable-fre')

args.append('--disable-external-intent-requests')

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »