chrome/browser/resources/print_preview/common/overlay.js - Issue 595153003: Compile print_preview, part 5: reduce down to 104 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/common/overlay.js

Issue 595153003: Compile print_preview, part 5: reduce down to 104 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_4

Patch Set: fix a comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/cloud_print_interface.js ('K') | « chrome/browser/resources/print_preview/cloud_print_interface.js ('k') | chrome/browser/resources/print_preview/data/destination_store.js » ('j') | chrome/browser/resources/print_preview/print_preview_animations.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/common/overlay.js

diff --git a/chrome/browser/resources/print_preview/common/overlay.js b/chrome/browser/resources/print_preview/common/overlay.js

index 4585dd64ae13a19e50a4addfae28fbac4cc04a78..635ae9b1c70c4c929472d43bc667353f0ae126cf 100644

--- a/chrome/browser/resources/print_preview/common/overlay.js

+++ b/chrome/browser/resources/print_preview/common/overlay.js

@@ -7,26 +7,16 @@ cr.define('print_preview', function() {

/**

* Modal dialog base component.

- * @param {!print_preview.MetricsContext} metricsContext Metrics

- * context to record usage statistics.

* @constructor

* @extends {print_preview.Component}

- function Overlay(metricsContext) {

+ function Overlay() {

print_preview.Component.call(this);

- /** @private {!print_preview.MetricsContext} */

- this.metricsContext_ = metricsContext;

};

Dan Beam 2014/09/24 23:31:21 nit: remove ;

Vitaly Pavlenko 2014/09/24 23:57:07 Done.

Overlay.prototype = {

__proto__: print_preview.Component.prototype,

- /** @return {!print_preview.MetricsContext} */

- get metricsContext() {

- return this.metricsContext_;

- },

/** @override */

enterDocument: function() {

print_preview.Component.prototype.enterDocument.call(this);