chrome/browser/resources/print_preview/preview_generator.js - Issue 595153003: Compile print_preview, part 5: reduce down to 104 errors

Unified Diff: chrome/browser/resources/print_preview/preview_generator.js

Issue 595153003: Compile print_preview, part 5: reduce down to 104 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_4

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/cloud_print_interface.js ('K') | « chrome/browser/resources/print_preview/native_layer.js ('k') | chrome/browser/resources/print_preview/print_preview_animations.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/preview_generator.js

diff --git a/chrome/browser/resources/print_preview/preview_generator.js b/chrome/browser/resources/print_preview/preview_generator.js

index bcbe95fe64ae8a8d73fcefa9611c185b34927a91..9298a8e78ec36b304f37fcc3a2c0f605b0ad794d 100644

--- a/chrome/browser/resources/print_preview/preview_generator.js

+++ b/chrome/browser/resources/print_preview/preview_generator.js

@@ -59,7 +59,7 @@ cr.define('print_preview', function() {

/**

* Media size to generate preview with. {@code null} indicates default size.

- * @type {cp.cdd.MediaSizeTicketItem}

+ * @type {print_preview.ticket_items.MediaSize}

Aleksey Shlyapnikov 2014/09/24 17:54:43 cp.cdd.MediaSizeTicketItem was a correct type, it

Vitaly Pavlenko 2014/09/24 20:39:50 Where is the type cp.cdd.MediaSizeTicketItem decla

Aleksey Shlyapnikov 2014/09/24 21:13:18 Well, it is supposed to be generated from proto de

Vitaly Pavlenko 2014/09/24 22:37:57 Done.

* @private

this.mediaSize_ = null;

@@ -94,7 +94,7 @@ cr.define('print_preview', function() {

/**

* Page ranges setting used used to generate the last preview.

- * @type {!Array.<object.<{from: number, to: number}>>}

+ * @type {Array.<Object.<{from: number, to: number}>>}

* @private

this.pageRanges_ = null;