Compile print_preview, part 5: reduce down to 104 errors

chrome/browser/resources/print_preview/print_preview_animations.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Counter used to give webkit animations unique names.
 var animationCounter = 0;
 
 var animationEventTracker_ = new EventTracker();
 
 function addAnimation(code) {
@@ skipping 55 matching lines @@
  * appearing underneath the textfields.
  * @param {HTMLElement} el The element to be faded out.
  */
 function fadeOutElement(el) {
   if (!el.classList.contains('visible'))
     return;
   fadeInAnimationCleanup(el);
   el.style.height = 'auto';
   var height = el.offsetHeight;
   el.style.height = height + 'px';
-  el.offsetHeight;  // Should force an update of the computed style.
+  /**
+   * Should force an update of the computed style.
+   * @suppress {uselessCode}

[Dan Beam, 2014/09/24 23:31:21]

i think this is supposed to be suspicious code, no?

[Dan Beam, 2014/09/24 23:31:21]

nit: just add a

  /** @supress {suspiciousCode} */
  el.offsetHeight;  // Should force an update of the computed style.

2\s + // comment

is a closure-style thing and this requires less lines and less of a change

[Vitaly Pavlenko, 2014/09/24 23:57:07]

Either way works.

[Vitaly Pavlenko, 2014/09/24 23:57:07]

Done.

+   */
+  el.offsetHeight;
   animationEventTracker_.add(
       el, 'webkitTransitionEnd', onFadeOutTransitionEnd.bind(el), false);
   el.classList.add('closing');
   el.classList.remove('visible');
   el.setAttribute('aria-hidden', 'true');
 }
 
 /**
  * Executes when a fade out animation ends.
  * @param {WebkitTransitionEvent} event The event that triggered this listener.
@@ skipping 35 matching lines @@
  * @param {HTMLElement} el The element to hide.
  * @param {boolean=} opt_justShow Whether {@code el} should be hidden with no
  *     animation.
  */
 function fadeInOption(el, opt_justShow) {
   if (el.classList.contains('visible'))
     return;
   // To make the option visible during the first fade in.
   el.hidden = false;
 
-  var leftColumn = el.querySelector('.left-column');
+  var leftColumn = assertInstanceof(el.querySelector('.left-column'),
+                                    HTMLElement);
   wrapContentsInDiv(leftColumn, ['invisible']);
-  var rightColumn = el.querySelector('.right-column');
+  var rightColumn = assertInstanceof(el.querySelector('.right-column'),
+                                     HTMLElement);
   wrapContentsInDiv(rightColumn, ['invisible']);
 
   var toAnimate = el.querySelectorAll('.collapsible');
   for (var i = 0; i < toAnimate.length; i++)
     fadeInElement(toAnimate[i], opt_justShow);
   el.classList.add('visible');
 }
 
 /**
  * Fades out a printing option existing under |el|.
  * @param {HTMLElement} el The element to hide.
  * @param {boolean=} opt_justHide Whether {@code el} should be hidden with no
  *     animation.
  */
 function fadeOutOption(el, opt_justHide) {
   if (!el.classList.contains('visible'))
     return;
 
-  var leftColumn = el.querySelector('.left-column');
+  var leftColumn = assertInstanceof(el.querySelector('.left-column'),
+                                    HTMLElement);
   wrapContentsInDiv(leftColumn, ['visible']);
-  var rightColumn = el.querySelector('.right-column');
+  var rightColumn = assertInstanceof(el.querySelector('.right-column'),
+                                     HTMLElement);
   wrapContentsInDiv(rightColumn, ['visible']);
 
   var toAnimate = el.querySelectorAll('.collapsible');
   for (var i = 0; i < toAnimate.length; i++) {
     if (opt_justHide) {
       toAnimate[i].hidden = true;
       toAnimate[i].classList.add('closing');
       toAnimate[i].classList.remove('visible');
     } else {
       fadeOutElement(toAnimate[i]);
     }
   }
   el.classList.remove('visible');
 }
 
 /**
  * Wraps the contents of |el| in a div element and attaches css classes
  * |classes| in the new div, only if has not been already done. It is necessary
  * for animating the height of table cells.
  * @param {HTMLElement} el The element to be processed.
- * @param {array} classes The css classes to add.
+ * @param {Array} classes The css classes to add.
  */
 function wrapContentsInDiv(el, classes) {
   var div = el.querySelector('div');
   if (!div || !div.classList.contains('collapsible')) {
     div = document.createElement('div');
     while (el.childNodes.length > 0)
       div.appendChild(el.firstChild);
     el.appendChild(div);
   }
 
   div.className = '';
   div.classList.add('collapsible');
   for (var i = 0; i < classes.length; i++)
     div.classList.add(classes[i]);
 }