Compile print_preview, part 5: reduce down to 104 errors

chrome/browser/resources/print_preview/cloud_print_interface.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('cloudprint', function() {
   'use strict';
 
   /**
    * API to the Google Cloud Print service.
    * @param {string} baseUrl Base part of the Google Cloud Print service URL
@@ skipping 49 matching lines @@
     /**
      * Stores last received XSRF tokens for each user account. Sent as
      * a parameter with every request.
      * @type {!Object.<string, string>}
      * @private
      */
     this.xsrfTokens_ = {};
 
     /**
      * Pending requests delayed until we get access token.
-     * @type {!Array.<!CloudPrintRequest>}
+     * @type {!Array.<!cloudprint.CloudPrintRequest>}
      * @private
      */
     this.requestQueue_ = [];
 
     /**
      * Outstanding cloud destination search requests.
-     * @type {!Array.<!CloudPrintRequest>}
+     * @type {!Array.<!cloudprint.CloudPrintRequest>}
      * @private
      */
     this.outstandingCloudSearchRequests_ = [];
 
     /**
      * Event tracker used to keep track of native layer events.
      * @type {!EventTracker}
      * @private
      */
     this.tracker_ = new EventTracker();
@@ skipping 222 matching lines @@
           destination.origin,
           destination.account,
           this.onSubmitDone_.bind(this));
       this.sendOrQueueRequest_(cpRequest);
     },
 
     /**
      * Sends a Google Cloud Print printer API request.
      * @param {string} printerId ID of the printer to lookup.
      * @param {!print_preview.Destination.Origin} origin Origin of the printer.
-     * @param {string=} account Account this printer is registered for. When
+     * @param {?string} account Account this printer is registered for. When
      *     provided for COOKIES {@code origin}, and users sessions are still not
      *     known, will be checked against the response (both success and failure
      *     to get printer) and, if the active user account is not the one
      *     requested, {@code account} is activated and printer request reissued.
      */
     printer: function(printerId, origin, account) {
       var params = [
         new HttpParam('printerid', printerId),
         new HttpParam('use_cdd', 'true'),
         new HttpParam('printer_connection_status', 'true')
@@ skipping 44 matching lines @@
      * @param {string} method HTTP method of the request.
      * @param {string} action Google Cloud Print action to perform.
      * @param {Array.<!HttpParam>} params HTTP parameters to include in the
      *     request.
      * @param {!print_preview.Destination.Origin} origin Origin for destination.
      * @param {?string} account Account the request is sent for. Can be
      *     {@code null} or empty string if the request is not cookie bound or
      *     is sent on behalf of the primary user.
      * @param {function(number, Object, !print_preview.Destination.Origin)}
      *     callback Callback to invoke when request completes.
-     * @return {!CloudPrintRequest} Partially prepared request.
+     * @return {!cloudprint.CloudPrintRequest} Partially prepared request.
      * @private
      */
     buildRequest_: function(method, action, params, origin, account, callback) {
       var url = this.baseUrl_ + '/' + action + '?xsrf=';
       if (origin == print_preview.Destination.Origin.COOKIES) {
+        account = assert(account);
         var xsrfToken = this.xsrfTokens_[account];
         if (!xsrfToken) {
           // TODO(rltoscano): Should throw an error if not a read-only action or
           // issue an xsrf token request.
         } else {
           url = url + xsrfToken;
         }
         if (account) {
           var index = this.userSessionIndex_[account] || 0;
           if (index > 0) {
@@ skipping 421 matching lines @@
     /**
      * Result for requests.
      * @type {Object} JSON response.
      */
     this.result = null;
   };
 
   /**
    * Data structure that represents an HTTP parameter.
    * @param {string} name Name of the parameter.
-   * @param {string} value Value of the parameter.
+   * @param {print_preview.ValueType} value Value of the parameter.
    * @constructor
    */
   function HttpParam(name, value) {
     /**
      * Name of the parameter.
      * @type {string}
      */
     this.name = name;
 
     /**
      * Name of the value.
      * @type {string}
      */
     this.value = value;
   };
 
   // Export
   return {
-    CloudPrintInterface: CloudPrintInterface
+    CloudPrintInterface: CloudPrintInterface,
+    CloudPrintRequest: CloudPrintRequest

[Aleksey Shlyapnikov, 2014/09/24 17:54:43]

Why are you exporting it? It's not used anywhere outside of this file.

[Vitaly Pavlenko, 2014/09/24 20:39:49]

Right now that's the only way to use the type cloudprint.CloudPrintRequest
inside this file inside JSDoc to make it visible for the compiler. It's ugly,
for sure. Is it acceptable to commit such a thing?

[Aleksey Shlyapnikov, 2014/09/24 21:13:17]

If we have no workaround, then yes. Let's add a comment why we export it though.

[Vitaly Pavlenko, 2014/09/24 22:37:57]

Done.

   };
 });