Enable isolate on Linux release builder.

Enable isolate on Linux release builder.

Fix coverage warning by removing old codepath. The two parameter version of find_isolated_tests has been called by GPU bots for a long time so we know it works.

BUG=414808
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292114

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292121

[jam, 2014-09-24 00:59:00]

jam@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2014-09-24 01:02:10]

lgtm

Just keep an eye on general compile time on the builder for slow down. There'll
be some, and Vadim will work on improving this but we just don't want the slow
down to be over the top. Since it's already used on the TS, it shouldn't be
catastrophic.

[jam, 2014-09-24 01:09:16]

On 2014/09/24 01:02:10, M-A Ruel wrote:
> lgtm
> 
> Just keep an eye on general compile time on the builder for slow down.
There'll
> be some, and Vadim will work on improving this but we just don't want the slow
> down to be over the top. Since it's already used on the TS, it shouldn't be
> catastrophic.

Thanks, I'll  keep an eye out for it. I've saved data for the last 200 builds
for the Linux testers for comparison of median running times. I'll save data for
the builders now as well. Good to double check, although as you say I'm not very
concerned about this because it has had low overhead on the try servers.

[jam, 2014-09-24 15:55:01]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-24 15:55:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595143002/40001

[commit-bot: I haz the power, 2014-09-24 15:56:30]

Committed patchset #3 (id:40001) as 292114

[jam, 2014-09-24 16:38:29]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/594153003/ by jam@chromium.org.

The reason for reverting is: breaks swarming on bots.

[jam, 2014-09-24 18:10:17]

Patchset #5 (id:80001) has been deleted

[jam, 2014-09-24 19:31:21]

Patchset #9 (id:170001) has been deleted

[jam, 2014-09-24 19:31:27]

Patchset #8 (id:150001) has been deleted

[jam, 2014-09-24 19:31:32]

Patchset #7 (id:130001) has been deleted

[jam, 2014-09-24 19:31:37]

Patchset #6 (id:110001) has been deleted

[jam, 2014-09-24 19:31:41]

Patchset #5 (id:90017) has been deleted

[jam, 2014-09-24 19:33:30]

jam@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[jam, 2014-09-24 19:33:30]

updated after revert

[M-A Ruel, 2014-09-24 19:37:01]

lgtm

https://codereview.chromium.org/595143002/diff/190001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/595143002/diff/190001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/api.py:224:
tests_including_triggered = copy.copy(tests)
tests_including_triggered = tests[:]

https://codereview.chromium.org/595143002/diff/190001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/api.py:241: isolated_targets =
[t.name for t in tests_including_triggered \
isolated_targets = [
  t.name for t in tests_including_triggered if t.uses_swarming
]

[jam, 2014-09-24 19:47:37]

Thanks

https://codereview.chromium.org/595143002/diff/190001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/595143002/diff/190001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/api.py:224:
tests_including_triggered = copy.copy(tests)
On 2014/09/24 19:37:00, M-A Ruel wrote:
> tests_including_triggered = tests[:]

Done.

https://codereview.chromium.org/595143002/diff/190001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/api.py:241: isolated_targets =
[t.name for t in tests_including_triggered \
On 2014/09/24 19:37:00, M-A Ruel wrote:
> isolated_targets = [
>   t.name for t in tests_including_triggered if t.uses_swarming
> ]

Done.

[jam, 2014-09-24 19:47:54]

jam@chromium.org changed reviewers:
- phajdan.jr@chromium.org

[jam, 2014-09-24 19:48:10]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-24 19:49:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595143002/210001

[commit-bot: I haz the power, 2014-09-24 19:50:50]

Committed patchset #6 (id:210001) as 292121