Issue 59513005: Hook up GL Command buffer on Windows too

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59513005: Hook up GL Command buffer on Windows too (Closed)

Created:
7 years, 1 month ago by Ben Goodger (Google)

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
	M	mojo/examples/sample_app/sample_app.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
	M	mojo/services/native_viewport/native_viewport_win.cc	View		4 chunks	+24 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

abarth-chromium

LGTM Once all these in-flight CLs land, I'll do a refactoring CL to extract the ...

7 years, 1 month ago (2013-11-06 02:19:34 UTC) #2

Ben Goodger (Google)

It turns out that I was #including a file in sample_app also that was not ...

7 years, 1 month ago (2013-11-06 04:19:52 UTC) #3

Ben Goodger (Google)

7 years, 1 month ago (2013-11-06 06:24:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r233235 (presubmit successful).