Save the client base JID for authentication in case it differs from the email (for accounts non-Goo…

remoting/webapp/signal_strategy.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 47 matching lines @@
 remoting.SignalStrategy.prototype.sendMessage = function(message) {};
 
 /** @return {remoting.SignalStrategy.State} Current state */
 remoting.SignalStrategy.prototype.getState = function() {};
 
 /** @return {remoting.Error} Error when in FAILED state. */
 remoting.SignalStrategy.prototype.getError = function() {};
 
 /** @return {string} Current JID when in CONNECTED state. */
 remoting.SignalStrategy.prototype.getJid = function() {};
+
+/** Creates the appropriate signal strategy for this environment.

[Sergey Ulanov, 2014/09/25 02:28:46]

nit: "/**" should be on its own line unless the whole comment fits a single
line.
nit: s/this/current/

[rmsousa, 2014/09/27 01:42:17]

Done.

+ * @param {function(remoting.SignalStrategy.State): void} onStateChangedCallback
+ * @return {remoting.SignalStrategy} New signal strategy object.
+ */
+remoting.SignalStrategy.create = function(onStateChangedCallback) {

[rmsousa, 2014/09/24 02:53:27]

I moved this here to keep the implementation selection logic in one place. Let
me know if you think it should be somewhere else.

+  // Only use XMPP when TCP API is available and TLS support is enabled. That's
+  // not the case for V1 app (socket API is available only to platform apps)
+  // and for Chrome releases before 38.
+  if (chrome.socket && chrome.socket.secure) {
+    return new remoting.XmppConnection(onStateChangedCallback);
+  } else {
+    return new remoting.WcsAdapter(onStateChangedCallback);
+  }
+};