Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 595063005: Save the client base JID for authentication in case it differs from the email (for accounts non-Goo… (Closed)

Created:
6 years, 2 months ago by rmsousa
Modified:
6 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Save the client base JID for authentication in case it differs from the email (for accounts non-Google email). Keep a separate email field for use in user-facing UIs, logs, etc. Using the existing host_owner field for the base JID guarantees the correct *functional* behavior (i.e. authentication-wise) if the new config is used with an older host (the only difference is aesthetic - in that older host some UI/logs may show an uglier address instead of the user email). BUG=224742 Committed: https://crrev.com/665bf309b93ea3c96c22ce75600beb40e2c083cb Cr-Commit-Position: refs/heads/master@{#297269}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Review comments #

Total comments: 1

Patch Set 3 : add jsdoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -40 lines) Patch
M remoting/host/chromoting_host.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/host/host_config.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M remoting/host/host_config.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/host_status_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/mac/me2me_preference_pane.mm View 1 chunk +10 lines, -6 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 5 chunks +27 lines, -1 line 0 comments Download
M remoting/host/win/elevated_controller.cc View 1 3 chunks +13 lines, -11 lines 0 comments Download
M remoting/webapp/host_controller.js View 1 2 5 chunks +79 lines, -7 lines 0 comments Download
M remoting/webapp/session_connector_impl.js View 1 chunk +2 lines, -10 lines 0 comments Download
M remoting/webapp/signal_strategy.js View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
rmsousa
Tested V1 and V2 on Linux. I haven't tested the Win/Mac UI changes yet - ...
6 years, 2 months ago (2014-09-24 02:53:28 UTC) #2
Sergey Ulanov
Looks mostly good. I'm just a bit concerned about adding complexity in host_controller.js . See ...
6 years, 2 months ago (2014-09-25 02:28:46 UTC) #3
rmsousa
https://codereview.chromium.org/595063005/diff/1/remoting/host/host_config.h File remoting/host/host_config.h (right): https://codereview.chromium.org/595063005/diff/1/remoting/host/host_config.h#newcode22 remoting/host/host_config.h:22: // Base JID of the owner of this host. ...
6 years, 2 months ago (2014-09-27 01:42:17 UTC) #4
Sergey Ulanov
lgtm https://codereview.chromium.org/595063005/diff/1/remoting/webapp/host_controller.js File remoting/webapp/host_controller.js (right): https://codereview.chromium.org/595063005/diff/1/remoting/webapp/host_controller.js#newcode228 remoting/webapp/host_controller.js:228: var onState = function(state) { On 2014/09/27 01:42:17, ...
6 years, 2 months ago (2014-09-27 01:46:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595063005/40001
6 years, 2 months ago (2014-09-29 20:17:47 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as f28f9795beff77cd669716197d2cd42a81aa654c
6 years, 2 months ago (2014-09-29 21:18:37 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:21:00 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/665bf309b93ea3c96c22ce75600beb40e2c083cb
Cr-Commit-Position: refs/heads/master@{#297269}

Powered by Google App Engine
This is Rietveld 408576698