Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 595063004: content: Fix OOM error handling in GpuMemoryBufferImplSharedMemory::AllocateSharedMemoryForChildPro… (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

content: Fix OOM error handling in GpuMemoryBufferImplSharedMemory::AllocateSharedMemoryForChildProcess. We need to run the callback with an empty handle after failing to allocated shared memory. BUG= TBR=piman@chromium.org Committed: https://crrev.com/ec689def26224911fa41c50e3b8908ea39c8afe1 Cr-Commit-Position: refs/heads/master@{#296333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
reveman
6 years, 2 months ago (2014-09-24 01:22:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595063004/1
6 years, 2 months ago (2014-09-24 01:24:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 053578b687c6f8c003da308cbf87cacdbf585cfd
6 years, 2 months ago (2014-09-24 02:58:43 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec689def26224911fa41c50e3b8908ea39c8afe1 Cr-Commit-Position: refs/heads/master@{#296333}
6 years, 2 months ago (2014-09-24 02:59:25 UTC) #5
piman
6 years, 2 months ago (2014-09-24 03:14:04 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698