Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 595063002: Use a JS dictionary to initialize a the fields in a Mojo struct (Closed)

Created:
6 years, 3 months ago by hansmuller
Modified:
6 years, 3 months ago
Reviewers:
mpcomplete, Matt Perry
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable using a JS dictionary to initialize a the fields in a Mojo struct. For example, to initialize a URLRequest: var urlRequest = new loader.URLRequest({ url: "http://www.cnn.com", method: "GET", auto_follow_redirects: true }); The value of unspecified fields is the Mojo default for the field's type. Values for fields that were not specified in the Mojom struct definition are ignored. BUG=416163 Committed: https://crrev.com/25584136ce30ad399720cf1af27c4579810beeaf Cr-Commit-Position: refs/heads/master@{#296410}

Patch Set 1 #

Patch Set 2 : Removed console module test dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -4 lines) Patch
A mojo/public/js/bindings/struct_unittests.js View 1 1 chunk +47 lines, -0 lines 0 comments Download
M mojo/public/js/bindings/tests/run_js_tests.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
hansmuller
This is a small change, PTAL.
6 years, 3 months ago (2014-09-23 23:26:33 UTC) #2
Matt Perry
LGTM
6 years, 3 months ago (2014-09-23 23:35:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595063002/20001
6 years, 3 months ago (2014-09-23 23:38:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/17800) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17732) ios_rel_device_ninja ...
6 years, 3 months ago (2014-09-24 00:04:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595063002/20001
6 years, 3 months ago (2014-09-24 00:22:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/17827) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17760) ios_rel_device_ninja ...
6 years, 3 months ago (2014-09-24 00:27:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595063002/20001
6 years, 3 months ago (2014-09-24 14:32:53 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9dcdc9f334530b8910b1e4983227c9c13da1ece3
6 years, 3 months ago (2014-09-24 14:43:48 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 14:44:28 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25584136ce30ad399720cf1af27c4579810beeaf
Cr-Commit-Position: refs/heads/master@{#296410}

Powered by Google App Engine
This is Rietveld 408576698