Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 595053002: mac: Fix StatusBubbleMacTest on OSX 10.10. (Closed)

Created:
6 years, 3 months ago by erikchen
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_spellcheck_test
Project:
chromium
Visibility:
Public.

Description

mac: Fix StatusBubbleMacTest on OSX 10.10. The test relied on implicit assumptions about the system font. The system font changed in OSX 10.10. I changed the test to always use a fixed font. BUG=390276 Committed: https://crrev.com/cc4cd11dc4f9419888190c04dea388c00b1487f2 Cr-Commit-Position: refs/heads/master@{#296616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
erikchen
avi: Please review.
6 years, 3 months ago (2014-09-23 22:30:47 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 3 months ago (2014-09-23 23:15:54 UTC) #3
erikchen
I've tested that this test works on all OSX versions. (10.6 through 10.10)
6 years, 3 months ago (2014-09-25 00:18:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595053002/1
6 years, 3 months ago (2014-09-25 00:20:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as dc9263bb846cd580dee5d87ecea8e3e9d5a14f54
6 years, 3 months ago (2014-09-25 01:47:00 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 01:47:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc4cd11dc4f9419888190c04dea388c00b1487f2
Cr-Commit-Position: refs/heads/master@{#296616}

Powered by Google App Engine
This is Rietveld 408576698