Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 595033002: Move declarative_webrequest_custom_bindings.js. and declarative_web_request.json. (Closed)

Created:
6 years, 3 months ago by Xi Han
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, wjmaclean, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move declarative_webrequest_custom_bindings.js. and declarative_web_request.json to //extensions. BUG=352293 Committed: https://crrev.com/faa99f8c03c439f26c5ff497d3804b0818f1cf2f Cr-Commit-Position: refs/heads/master@{#296484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -707 lines) Patch
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/declarative_web_request.json View 1 chunk +0 lines, -597 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_models_test.py View 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/platform_bundle_test.py View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js View 1 chunk +0 lines, -96 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
A + extensions/common/api/declarative_web_request.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A + extensions/renderer/resources/declarative_webrequest_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
Xi Han
6 years, 3 months ago (2014-09-23 21:56:05 UTC) #2
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-23 22:40:45 UTC) #4
Xi Han
rockot@chromium.org: Please review all changes. Thanks a lot!
6 years, 3 months ago (2014-09-24 14:25:59 UTC) #7
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-24 17:15:38 UTC) #8
Xi Han
sky@chromium.org: Please review changes in -chrome/common/extensions_api_resources.grd -chrome/renderer/resources/renderer_resources.grd Thanks!
6 years, 3 months ago (2014-09-24 17:18:41 UTC) #10
sky
LGTM
6 years, 3 months ago (2014-09-24 17:22:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595033002/40001
6 years, 3 months ago (2014-09-24 17:30:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13195)
6 years, 3 months ago (2014-09-24 17:43:30 UTC) #17
Ken Rockot(use gerrit already)
On 2014/09/24 17:43:30, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-09-24 17:47:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595033002/40001
6 years, 3 months ago (2014-09-24 19:16:05 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:40001) as 6def571e41d31ea4610f3b4ac62f5956a7129e2d
6 years, 3 months ago (2014-09-24 19:17:50 UTC) #21
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 19:18:29 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faa99f8c03c439f26c5ff497d3804b0818f1cf2f
Cr-Commit-Position: refs/heads/master@{#296484}

Powered by Google App Engine
This is Rietveld 408576698