DescriptionUse entry URLs instead of entry IDs to determine when to dismiss the overscroll overlay.
This is a band-aid fix for crbug.com/415167, which I'd like to try to get into M38.
Apparently it's possible to have "temporary" entry IDs set as pending and then
thrown away. This confuses OverscrollNavigationOverlay into thinking that the
page was never loaded and the overlay never gets dismissed as a result, which
makes the webpage unusable.
Using URLs is not as reliable avoids this problem. It can introduce false
positives in some corner cases, however a false positive doesn't have severe
consequences - we simply dismiss the overlay too soon, and the use may see an
empty page or a flicker.
BUG=415167
TBR=creis@chromium.org
Review URL: https://codereview.chromium.org/575203002
Cr-Commit-Position: refs/heads/master@{#295811}
(cherry picked from commit c0f6e41d97c2527b165600f3a9e139a813b35b81)
Committed: https://chromium.googlesource.com/chromium/src/+/b796e57f71305f46ac9caafbe025ff6a4f649ba0
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|