Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 594953002: Use entry URLs instead of entry IDs to determine when to dismiss the overscroll overlay. (Closed)

Created:
6 years, 3 months ago by mfomitchev
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Use entry URLs instead of entry IDs to determine when to dismiss the overscroll overlay. This is a band-aid fix for crbug.com/415167, which I'd like to try to get into M38. Apparently it's possible to have "temporary" entry IDs set as pending and then thrown away. This confuses OverscrollNavigationOverlay into thinking that the page was never loaded and the overlay never gets dismissed as a result, which makes the webpage unusable. Using URLs is not as reliable avoids this problem. It can introduce false positives in some corner cases, however a false positive doesn't have severe consequences - we simply dismiss the overlay too soon, and the use may see an empty page or a flicker. BUG=415167 TBR=creis@chromium.org Review URL: https://codereview.chromium.org/575203002 Cr-Commit-Position: refs/heads/master@{#295811} (cherry picked from commit c0f6e41d97c2527b165600f3a9e139a813b35b81) Committed: https://chromium.googlesource.com/chromium/src/+/b796e57f71305f46ac9caafbe025ff6a4f649ba0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -27 lines) Patch
M content/browser/web_contents/aura/overscroll_navigation_overlay.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.cc View 5 chunks +29 lines, -15 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mfomitchev
6 years, 3 months ago (2014-09-23 19:04:56 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as b796e57 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698