Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 594883002: Revert of Fix the way how we create webrtc::AudioProcessing in Chrome (Closed)

Created:
6 years, 3 months ago by no longer working on chromium
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix the way how we create webrtc::AudioProcessing in Chrome (patchset #5 id:100001 of https://codereview.chromium.org/588523002/) Reason for revert: It broke some internal webrtc bots, revert it for now and will reland it after fixing the problems. http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Mac%20Tester/builds/22092 Original issue's description: > Fix the way how we create webrtc::AudioProcessing in Chrome. > > BUG=415935 > TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist. > > Committed: https://crrev.com/a5e9fc62b7bf25931ffe6153cc738098d8119c28 > Cr-Commit-Position: refs/heads/master@{#295990} TBR=tommi@chromium.org NOTREECHECKS=true NOTRY=true BUG=415935 Committed: https://crrev.com/e5d4e40f138c70432e05101b2ebea7b305aa0341 Cr-Commit-Position: refs/heads/master@{#296191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -41 lines) Patch
M content/renderer/media/media_stream_audio_processor.cc View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 4 chunks +1 line, -12 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 5 chunks +1 line, -20 lines 0 comments Download
M third_party/libjingle/overrides/initialize_module.cc View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
no longer working on chromium
Created Revert of Fix the way how we create webrtc::AudioProcessing in Chrome
6 years, 3 months ago (2014-09-23 15:31:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594883002/1
6 years, 3 months ago (2014-09-23 15:32:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as cfb5a2ec04907b92c285c020d0861e85c4dd40c8
6 years, 3 months ago (2014-09-23 15:32:38 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 15:33:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5d4e40f138c70432e05101b2ebea7b305aa0341
Cr-Commit-Position: refs/heads/master@{#296191}

Powered by Google App Engine
This is Rietveld 408576698