Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 594843004: Summary tag is exposed with wrong IA2 Role (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXRenderObject.cpp
diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp
index 8ee9d6547dc7c27e12223599572869565d9e5858..15b0a3bc16890c0844e79e89e686dbcc9597d03a 100644
--- a/Source/core/accessibility/AXRenderObject.cpp
+++ b/Source/core/accessibility/AXRenderObject.cpp
@@ -280,6 +280,11 @@ AccessibilityRole AXRenderObject::determineAccessibilityRole()
return buttonRoleType();
if (isHTMLDetailsElement(node))
return DetailsRole;
+ if (isHTMLSummaryElement(node)) {
+ if (isHTMLDetailsElement(m_renderer->parent()->node()))
Mike West 2014/09/25 13:08:01 I think you need to null-check parent() here. Othe
dmazzoni 2014/09/25 15:19:49 Also, I think it'd be more correct to check node->
+ return DisclosureTriangleRole;
+ return UnknownRole;
+ }
if (isHTMLLegendElement(node))
return LegendRole;
if (m_renderer->isText())
« no previous file with comments | « Source/core/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698