Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 594843004: Summary tag is exposed with wrong IA2 Role (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Incorporating comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 return ariaRole; 186 return ariaRole;
187 187
188 if (node()->isLink()) 188 if (node()->isLink())
189 return LinkRole; 189 return LinkRole;
190 if (node()->isTextNode()) 190 if (node()->isTextNode())
191 return StaticTextRole; 191 return StaticTextRole;
192 if (isHTMLButtonElement(*node())) 192 if (isHTMLButtonElement(*node()))
193 return buttonRoleType(); 193 return buttonRoleType();
194 if (isHTMLDetailsElement(*node())) 194 if (isHTMLDetailsElement(*node()))
195 return DetailsRole; 195 return DetailsRole;
196 if (isHTMLSummaryElement(*node())) {
197 if (node()->parentNode() && isHTMLDetailsElement(node()->parentNode()))
198 return DisclosureTriangleRole;
199 return UnknownRole;
200 }
201
196 if (isHTMLInputElement(*node())) { 202 if (isHTMLInputElement(*node())) {
197 HTMLInputElement& input = toHTMLInputElement(*node()); 203 HTMLInputElement& input = toHTMLInputElement(*node());
198 const AtomicString& type = input.type(); 204 const AtomicString& type = input.type();
199 if (type == InputTypeNames::checkbox) 205 if (type == InputTypeNames::checkbox)
200 return CheckBoxRole; 206 return CheckBoxRole;
201 if (type == InputTypeNames::radio) 207 if (type == InputTypeNames::radio)
202 return RadioButtonRole; 208 return RadioButtonRole;
203 if (input.isTextButton()) 209 if (input.isTextButton())
204 return buttonRoleType(); 210 return buttonRoleType();
205 if (type == InputTypeNames::range) 211 if (type == InputTypeNames::range)
(...skipping 1492 matching lines...) Expand 10 before | Expand all | Expand 10 after
1698 float range = maxValueForRange() - minValueForRange(); 1704 float range = maxValueForRange() - minValueForRange();
1699 float value = valueForRange(); 1705 float value = valueForRange();
1700 1706
1701 value += range * (percentChange / 100); 1707 value += range * (percentChange / 100);
1702 setValue(String::number(value)); 1708 setValue(String::number(value));
1703 1709
1704 axObjectCache()->postNotification(node(), AXObjectCache::AXValueChanged, tru e); 1710 axObjectCache()->postNotification(node(), AXObjectCache::AXValueChanged, tru e);
1705 } 1711 }
1706 1712
1707 } // namespace blink 1713 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/core/accessibility/AXRenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698