Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: ui/base/ui_base_tests.gyp

Issue 594843002: Reland https://codereview.chromium.org/581983003/: Enable ASan default options on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/framework.order ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ui_base_tests.gyp
diff --git a/ui/base/ui_base_tests.gyp b/ui/base/ui_base_tests.gyp
index 945a9ec2d805f1b15140ba581135b0384b55a234..3d015a0431c5c10fd542b55d77c3f2c143f87099 100644
--- a/ui/base/ui_base_tests.gyp
+++ b/ui/base/ui_base_tests.gyp
@@ -245,6 +245,17 @@
'../resources/ui_resources.gyp:ui_test_pak',
],
'includes': [ 'ui_base_tests_bundle.gypi' ],
+ # ui_base_tests_bundle doesn't actually contain a shared library and
Nico 2015/09/17 04:12:01 …wouldn't it be a better fix to make this target n
+ # therefore should not depend on sanitizer_options or any other
+ # libraries. Adding such a dependency will result in creating a
+ # broken shared library within the bundle.
+ 'conditions': [
+ ['use_sanitizer_options==1', {
+ 'dependencies!': [
+ '../../build/sanitizers/sanitizers.gyp:sanitizer_options',
+ ],
+ }],
+ ],
},
],
}],
« no previous file with comments | « chrome/app/framework.order ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698