Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: remoting/protocol/jingle_session_unittest.cc

Issue 594743002: Fix side-effect in DCHECK that breaks another DCHECK in JingleSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/jingle_session.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/jingle_session_unittest.cc
diff --git a/remoting/protocol/jingle_session_unittest.cc b/remoting/protocol/jingle_session_unittest.cc
index d7ce22896d4f9207a0bbcd28fa5f900196c8d9cf..27881371a3295f1932533fb981ac3e094b599aca 100644
--- a/remoting/protocol/jingle_session_unittest.cc
+++ b/remoting/protocol/jingle_session_unittest.cc
@@ -521,5 +521,19 @@ TEST_F(JingleSessionTest, TestFailedChannelAuth) {
EXPECT_TRUE(!host_socket_.get());
}
+TEST_F(JingleSessionTest, TestCancelChannelCreation) {
+ CreateSessionManagers(1, FakeAuthenticator::REJECT_CHANNEL);
+ ASSERT_NO_FATAL_FAILURE(
+ InitiateConnection(1, FakeAuthenticator::ACCEPT, false));
+
+ client_session_->GetTransportChannelFactory()->CreateChannel(
+ kChannelName, base::Bind(&JingleSessionTest::OnClientChannelCreated,
+ base::Unretained(this)));
+ client_session_->GetTransportChannelFactory()->CancelChannelCreation(
+ kChannelName);
+
+ EXPECT_TRUE(!client_socket_.get());
+}
+
} // namespace protocol
} // namespace remoting
« no previous file with comments | « remoting/protocol/jingle_session.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698