Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 594743002: Fix side-effect in DCHECK that breaks another DCHECK in JingleSession. (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix side-effect in DCHECK that breaks another DCHECK in JingleSession. DCHECK(!channels_[name]) adds NULL channel with |name| into the map, which was breaking DCHECK in JingleSession destructor. Replaced with another DCHECK that doesn't have side-effects. Added unittest to catch this problem. Also removed no-op line from ~JingleSession(). Committed: https://crrev.com/8668e3f025c0acc5c77dfb54755835f5f91a5270 Cr-Commit-Position: refs/heads/master@{#296224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M remoting/protocol/jingle_session.cc View 2 chunks +1 line, -2 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-23 00:59:10 UTC) #2
Wez
lgtm
6 years, 3 months ago (2014-09-23 16:28:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594743002/1
6 years, 3 months ago (2014-09-23 16:28:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c020f8d8fb6fb149b1efa9f580d70fe4ea4f3682
6 years, 3 months ago (2014-09-23 20:45:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 20:45:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8668e3f025c0acc5c77dfb54755835f5f91a5270
Cr-Commit-Position: refs/heads/master@{#296224}

Powered by Google App Engine
This is Rietveld 408576698